-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solver for distributed triangular systems #1236
Add solver for distributed triangular systems #1236
Conversation
…ll cases covered, may be inefficient, no tests so far!)
Things to be addressed:
|
Thank you for the PR! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
- Coverage 92.06% 92.04% -0.02%
==========================================
Files 80 80
Lines 11941 12031 +90
==========================================
+ Hits 10993 11074 +81
- Misses 948 957 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for the PR! |
Thank you for the PR! |
This pull request is stale because it has been open for 60 days with no activity. |
Thank you for the PR! |
Things to be done:
|
Thank you for the PR! |
Thank you for the PR! |
Thank you for the PR! |
Thank you for the PR! |
Thank you for the PR! |
There seems to be an error that is not due to the (meanwhile) resolved QR errors etc. |
Thank you for the PR! |
Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the changes @mrfh92 @FOsterfeld , looks great, I only have a few more editing suggestions.
Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
Thank you for the PR! |
1 similar comment
Thank you for the PR! |
incorporated @ClaudiaComito's suggestions for docstring
@ClaudiaComito I have taken your review into account now. |
Thank you for the PR! |
1 similar comment
Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @FOsterfeld , @mrfh92 !
Thank you for the PR! |
* solve_triangular from previous pr #1236 * added test for type and value errors --------- Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
This PR is intended to add a triangular solver (see, e.g.,
torch.linalg.solve_triangular
) to Heat; see #1096.Due Diligence
main
for new features, latest release branch (e.g.release/1.3.x
) for bug fixes